Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7029] Segfault when processing ospf.advrouter custom column

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7029

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8137|                            |review_for_checkin-
              Flags|                            |

--- Comment #4 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-04-03 11:15:54 PDT ---
Created attachment 8137
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8137
Fix string buffer overflows

(In reply to comment #0)
> Tshark will segfault when processing an ospf.advrouter custom column field when
> there are "too many" items in the field.
> 
> The following tshark command will trigger the segfault with the attached one
> packet tracefile: 
> 
> tshark -r ospf-lsa.pcap -o 'column.format: "Advertising Router",
> "%Cus:ospf.advrouter:0:R"'
> 
> The following tshark command will allow one to see the all 49 items in the
> "ospf.advrouter" field:
> 
> tshark -r ospf-lsa.pcap -T fields -e ospf.advrouter
> 
> I haven't had any time to look at source, but I suspect this problem may NOT be
> limited to just the ospf.advrouter field but for any custom column that might
> contain "too many" items.

Yep, AFAIR columns has limit of 256 bytes.
If you want bigger one you need to change sources.

Attached patch fix crash. Can you try it?

I'll later think about nicer solution of fixing it...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.