Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6995] Implementing dissector for PCEP extension according RFC 5886

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6995

Jaap Keuter <jaap.keuter@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8100|review_for_checkin?         |review_for_checkin-
              Flags|                            |

--- Comment #10 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2012-03-28 22:54:47 PDT ---
Comment on attachment 8100
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8100
Patch file for adding RFC 5886 support to PCEP protocol

Getting closer, but not there yet.

Don't remove the $Id$ tag. List your contributions at the end of the header
block.

Don't just retrieve flags/IPv4/IPv6/integer, then add them with
proto_tree_add_{boolean|ipv4/ipv6/uint}. Always try to aim at using
proto_tree_add_item, where the header field is used to define value access and
presentation. This makes all this code much more readable.

Be consistent with indentation (spaces / tabs do make a difference)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.