Wireshark-bugs: [Wireshark-bugs] [Bug 5881] Media Independent handover (MIH) protocol dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
--- Comment #25 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2012-03-22 06:55:14 PDT ---
(In reply to comment #23)
> (In reply to comment #22)
> > (In reply to comment #21)
> > > Created an attachment (id=7565) [details]
> > > MIH protocol dissector patch
> > >
> > > 1)It is not possible to replace proto_tree_add_text by proto_tree_add_item ?
> > > (Make field filterable ?
> > > --> the proto_tree_add_text at line no. 591 (for dissection of MIH type), is
> > > used to make the output more readable. However the MIh type field is
> > > filterable, because it is used when the corresponding tree is expanded.
> > > --> If there is anywhere else I have to change the API please let me know the
> > > line number.
> > >
> > line : 638, 641, 645, 651, 654, 656, 659, 668 1765, 1777, 1787, 1792, 1800...
> >
>
> --> I am sorry but I dont see any requirement of defining all the variables and
> the adding them using proto_tree_add_item. However if you still insist, I would
> consider doing it.
Generally, basically everything should be filterable. I usually argue that
even the spare bytes in packets should be filterable (because I once used such
a filter to verify that one entity was putting a non-zero value in there and
another entity was getting confused by that).
proto_tree_add_text() should only be used as is described in README.developer:
as something to hang other items off of.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
