Wireshark-bugs: [Wireshark-bugs] [Bug 5881] Media Independent handover (MIH) protocol dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
--- Comment #23 from Ankith <ankitha@xxxxxxx> 2012-03-22 02:24:07 PDT ---
(In reply to comment #22)
> (In reply to comment #21)
> > Created an attachment (id=7565) [details]
> > MIH protocol dissector patch
> >
> > 1)It is not possible to replace proto_tree_add_text by proto_tree_add_item ?
> > (Make field filterable ?
> > --> the proto_tree_add_text at line no. 591 (for dissection of MIH type), is
> > used to make the output more readable. However the MIh type field is
> > filterable, because it is used when the corresponding tree is expanded.
> > --> If there is anywhere else I have to change the API please let me know the
> > line number.
> >
> line : 638, 641, 645, 651, 654, 656, 659, 668 1765, 1777, 1787, 1792, 1800...
>
--> I am sorry but I dont see any requirement of defining all the variables and
the adding them using proto_tree_add_item. However if you still insist, I would
consider doing it.
>
> > 2)Also for function dissect_cmd_list / dissect_evt_list / dissect_mob_mgmt /
> > dissect_cfg_mthds, why not use value_string ?
> > --> A value_string datatype cannot be used because these functions dissect a
> > Bitmap, ie, each bit specifies whether the corresponding event is supported, so
> > all the if conditions are to be checked. If there is any better solution please
> > let me know.
> >
> Oups sorry look proto_tree_add_item (with FT_BOOLEAN type and bitmask field)
> with proto_tree_add_bitmask function (See Readme.dev guide)
>
> proto_tree_add_boolean_bits_format_value(ver_flags_tree,
> hf_mih_ack_req, tvb, (offset*8) + 4, 1, FALSE, "%d", tvb_get_bits8(tvb, 4, 1));
> may be replace also by proto_tree_add_item
>
> Also checkhf get a warning :
> Unused entry: epan/dissectors/packet-mih.c, hf_mih_value
-->removed the entry.
> Also some warning with tools fix-encodings-args.pl
--> fixed the encodings.
>
> Missing also the modification of epan/CMakeLists.txt
--> done.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
