Wireshark-bugs: [Wireshark-bugs] [Bug 6961] New dissector for the HART/IP protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6961
Bill Meier <wmeier@xxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #6 from Bill Meier <wmeier@xxxxxxxxxxx> 2012-03-18 13:31:47 PDT ---
Committed (with a few changes by me) in SVN # 41644
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=41644
Note: In the AUTHORS file I used the EMail address given for you in
packet-hartip.c. If you'd rather use a different EMail address in the AUTHORS
file (such as the one on the bug report) please let me know.
1. The main changes I made were:
a. Remove the call to hartip_set_conversation() in:
case SESSION_INITIATE_ID:
hartip_set_conversation(pinfo);
AFAIKT this call is redundant;
b.Minor changes relating to best practices for using the Wireshark API
(check_col not req'd, use of tvb_reported_length(), ...)
c. Some reformatting of the code.
If I've there's anything which needs to be changed, please let me know.
2. Can you provide a capture file which exercises more of the dissector
code ? E.g., the UDP conversation stuff and dissect_packAscii().
The capture file provided has only Pass-Through and Keep-Alive
HART/IP messages.
3. It would be appreciated if you could add a page to wiki.wireshark.org about
this protocol.
(From doc/README.developer)
- Create a Wiki page on the protocol at <http://wiki.wireshark.org>.
A template is provided so it is easy to setup in a consistent style.
See: <http://wiki.wireshark.org/HowToEdit>
and <http://wiki.wireshark.org/ProtocolReference>
Thanks for your contribution !
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
