Wireshark-bugs: [Wireshark-bugs] [Bug 6953] dissector for Kismet drone/server protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 16 Mar 2012 10:55:34 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6953

--- Comment #3 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-03-16 10:55:34 PDT ---
Hi,

Your dissector don't compile under Linux...
packet-kdsp.c:314:35: error: parameter 'pinfo' set but not used
[-Werror=unused-but-set-parameter]
Only need to add _U_ after packet_info pinfo 

The checkhf script report a unused hf_ entries :
Unused entry: epan/dissectors/packet-kdsp.c, hf_kdsp_pdu

Start also your hf_ entries by hf_kdsp_...

proto_tree_add_item()'s last argument should no longer be TRUE/FALSE but
ENC_*.  tools/fix-encoding-args.pl will help fix that for you.

What the indent of your file ? space or tab ? because there is a mix of both..
Also add modelines information too

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.