Wireshark-bugs: [Wireshark-bugs] [Bug 6938] RFC3261 CSeq number is allowed to exceed 2**31-1
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 12 Mar 2012 18:09:33 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6938

Michael Mann <mmann78@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8008|                            |review_for_checkin?
              Flags|                            |

--- Comment #4 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-03-12 18:09:32 PDT ---
Created attachment 8008
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8008
Bugfix CSeq + others

The attached patch fixes the bug by using strtoul() instead of atoi().  In
looking at the dissector there were a few more places where strtoul() should be
used over atoi().  I took the liberty of using the existing variable names and
formatting strings to determine if atoi or strtoul should be used and updated
appropriately.

Some places, like "send-to port", the dissector can get away with atoi()
because port is a 16-bit number.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.