Wireshark-bugs: [Wireshark-bugs] [Bug 6903] Dissector for the NXP PN532 protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 12 Mar 2012 12:29:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6903

--- Comment #10 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-03-12 12:29:24 PDT ---
(In reply to comment #9)
> (In reply to comment #7)
> > Things like col_set_str() and call_dissector() must not be within an if (tree)
> > {...} block.
> > 
> > (I have been unable to access the subversion archives to commit a change myself
> > since the recent site migration, so maybe someone else could fix this?)
> 
> Hi Chris,
> I have attached a fix ! If it is good for you, i commit !

Well, if tree is NULL, then pn532_tree will also be NULL, so there's no need to
make these calls either:

proto_tree_add_item(pn532_tree, hf_pn532_direction, tvb, 0, 1, ENC_NA);
etc.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.