Wireshark-bugs: [Wireshark-bugs] [Bug 6921] GMR-1: Add dissections for various GMR 04.08 element
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 7 Mar 2012 22:35:40 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

--- Comment #4 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-03-07 22:35:40 PST ---
Hi,
Wouldn't it be much better to use ELEM_MAND_TLV and friends from
packet-gsm_a_common.h? At a glance some IEs looks to be shared with
packet-gsm_a_rr.c
and could be reused from there rather than duplicate value_strings etc.

Add a new PDU type after
#define BSSGP_PDU_TYPE              13
And extend SET_ELEM_VARS etc
Regards
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.