Wireshark-bugs: [Wireshark-bugs] [Bug 6915] New: Update the h.248 dissector's package registrati
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 6 Mar 2012 07:18:36 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915

           Summary: Update the h.248 dissector's package registration to
                    support v1 packets.
           Product: Wireshark
           Version: SVN
          Platform: x86
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: alindber@xxxxxxxxx


Created attachment 7962
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7962
svn diff

Build Information:
./tshark -v
TShark 1.6.6 (SVN Rev 41372 from /trunk-1.6)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GLib 2.30.2, with libpcap (version unknown), with libz
1.2.6, with POSIX capabilities (Linux), without libpcre, with SMI 0.4.8, with
c-ares 1.7.5, with Lua 5.1, without Python, with GnuTLS 2.12.16, with Gcrypt
1.5.0, with MIT Kerberos, with GeoIP.

Running on Linux 3.2.0-1-686-pae, with libpcap version 1.2.1, with libz 1.2.6.

Built using gcc 4.6.2.

--
Update h.248 package registration to provide for V1 packets.

Modified registration function to use a b-tree to store registered packages.
The new registration function has an additional parameter that determines how
the new package should be added.

 ADD_PKG        /* add package at registration ONLY if no matching package ID
*/
                /* excluding the default packages loaded at registration */
 REPLACE_PKG    /* replace/add package at registration */
 MERGE_PKG_HIGH /* merge h248_package_t at registration favor new package */
 MERGE_PKG_LOW  /* merge h248_package_t at registration favor current package
*/

Packages now use a value_string[0] for package properties as the package name. 
This removes the need to modify the packet-h248-template.c file when adding new
packages.

ALL previously packages defined in the value_string arrays along with their
events and signals are loaded during initialization and set in the tree as
default.

All h.248 packages present in the SVN tree where updated to reflect the new
registration.  In addition, updates to some of the base h.248 files where
added.

Also added is a "magic number" field that is the first 4 bytes of the h.248
packet after the tpkt header.  These 4 bytes can be used to determine if it is
a true h.248 packet or some other protocol using the same tcp port number and
following the tpkt header. This field removes the need to use the heuristic
functions in my case of custom protocols.

Files updated are:
  asn1/h248/packet-h248-template.c
  asn1/h248/h248v1support.asn
  asn1/h248/packet-h248-template.h
  asn1/h248/h248.cnf
  epan/libwireshark.def
  epan/dissectors/packet-h248_3gpp.c
  epan/dissectors/packet-h248_annex_c.c
  epan/dissectors/packet-h248_q1950.c
  epan/dissectors/packet-h248_annex_e.c
  epan/dissectors/packet-h248_10.c
  epan/dissectors/packet-h248.c
  epan/dissectors/packet-h248.h
  epan/dissectors/packet-h248_7.c

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.