Wireshark-bugs: [Wireshark-bugs] [Bug 6881] Support for MPLS Packet Loss and Delay Measurement,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 29 Feb 2012 08:50:13 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6881

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #1 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-29 08:50:13 PST ---
Hi Francesco,

it is possible to attach a sample of packet with RFC6374 ?

the CheckAPI is not happy with packet-mpls-pm.c
/tools/checkAPIs.pl epan/dissectors/packet-mpls-pm.c 
Warning: epan/dissectors/packet-mpls-pm.c does not have an SVN Id tag.
Error: epan/dissectors/packet-mpls-pm.c   : Missing 'const': value_string
pmt_vals[]

There is some warning with Clang compiler :
packet-mpls-pm.c:715:5: warning: Value stored to 'rptf' is never read
packet-mpls-pm.c:839:5: warning: Value stored to 'rptf' is never read

Also there missing the modification for Cmake (epan/CMakeLists.txt)

Why not use proto_tree_add_item when there is uint64 ? (example :            
proto_tree_add_uint64_format(pm_tree, hf_mpls_pm_counter1, tvb,
                                         offset, 8,
                                         tvb_get_ntoh64(tvb, offset),
                                         "Counter 1 "
                                         "(B_TxP): %"G_GINT64_MODIFIER"u",
                                         tvb_get_ntoh64(tvb, offset));)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.