Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6862] CIP Safety dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6862

--- Comment #1 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-24 01:11:42 PST ---
the code don't compile under Ubuntu :
packet-cip.c: In function 'dissect_cip_date_and_time':
packet-cip.c:3198:78: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_unid':
packet-cipsafety.c:419:4: error: format not a string literal and no format
arguments [-Werror=format-security]
packet-cipsafety.c: In function 'dissect_s_supervisor_configuration_unid':
packet-cipsafety.c:757:77: error: unused parameter 'tree'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_supervisor_safety_configuration_id':
packet-cipsafety.c:772:82: error: unused parameter 'tree'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_supervisor_target_unid':
packet-cipsafety.c:787:70: error: unused parameter 'tree'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_supervisor_proposed_tunid':
packet-cipsafety.c:856:73: error: unused parameter 'tree'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_type':
packet-cipsafety.c:876:43: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c:876:80: error: unused parameter 'item'
[-Werror=unused-parameter]
packet-cipsafety.c:877:46: error: unused parameter 'total_len'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_time_coord_msg_min_mult':
packet-cipsafety.c:889:62: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c:889:99: error: unused parameter 'item'
[-Werror=unused-parameter]
packet-cipsafety.c:890:46: error: unused parameter 'total_len'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_network_time_multiplier':
packet-cipsafety.c:904:62: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c:904:99: error: unused parameter 'item'
[-Werror=unused-parameter]
packet-cipsafety.c:905:46: error: unused parameter 'total_len'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_timeout_multiplier':
packet-cipsafety.c:919:57: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c:919:94: error: unused parameter 'item'
[-Werror=unused-parameter]
packet-cipsafety.c:920:46: error: unused parameter 'total_len'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_coordination_conn_inst':
packet-cipsafety.c:934:61: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c:934:98: error: unused parameter 'item'
[-Werror=unused-parameter]
packet-cipsafety.c:935:46: error: unused parameter 'total_len'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_app_data_path':
packet-cipsafety.c:949:71: error: unused parameter 'tree'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_s_validator_prod_cons_fault_count':
packet-cipsafety.c:956:60: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c:956:97: error: unused parameter 'item'
[-Werror=unused-parameter]
packet-cipsafety.c:957:46: error: unused parameter 'total_len'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_ack_byte':
packet-cipsafety.c:1226:11: warning: variable 'ack_byte' set but not used
[-Wunused-but-set-variable]
packet-cipsafety.c:1222:77: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_mcast_byte':
packet-cipsafety.c:1246:11: warning: variable 'mcast_byte' set but not used
[-Wunused-but-set-variable]
packet-cipsafety.c:1242:79: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-cipsafety.c: In function 'dissect_cip_safety_data':
packet-cipsafety.c:1262:81: error: unused parameter 'offset'
[-Werror=unused-parameter]

It is possible to fix that ?

Also any news about the sample ?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.