Wireshark-bugs: [Wireshark-bugs] [Bug 5451] RTP-MIDI - dissector for transmission of MIDI-comman
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 23 Feb 2012 23:10:17 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5451

--- Comment #10 from Tobias Erichsen <t.erichsen@xxxxxx> 2012-02-23 23:10:15 PST ---
Hi Anders,

> Could you fold the .h file into the .c file we prefere to only have .h files
> if it needs to be included by other dissectors. Please put the default payload
> type to 0 as to not conflict with people that do not have RTP-MIDI as their
> favourite payload. proto_add_item()s encoding argument has changed from FALSE
> to ENC_BIG_ENDIAN there is a script in the tools folder to change that.

I will implement those changes.  I also need to adapt "packet-applemidi.c"
to now set the dynamic payload-type via rtp_add_address - I have done
that in a testcase and it seems to work nicely.

Concerning the proto_tree_add_item change to ENC_BIG_ENDIAN, I was wondering
what to do with the fields that are string-values?

Will the script automatically do the right thing there?

Best regards,
Tobias

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.