Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6844] Universal Alcatel Protocol - Reloaded

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

--- Comment #11 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-22 03:01:37 PST ---
There is some Clang Warning too :
packet-uasip.c:262:4: warning: Value stored to 'offset' is never read
packet-uaudp.c:286:13: warning: Value stored to 'offset' is never read
packet-noe.c:1345:4: warning: Value stored to 'length' is never read

and there some warning with checkhf 
./tools/checkhf.pl epan/dissectors/packet-noe.c
Unused entry: epan/dissectors/packet-noe.c, hf_noe_pcode
Unused entry: epan/dissectors/packet-noe.c, hf_noe_psize
Unused entry: epan/dissectors/packet-noe.c, hf_noe_aindx

And error with checkAPI
./tools/checkAPIs.pl epan/dissectors/packet-ua*
Error: Found %ll in epan/dissectors/packet-ua3g.c
Warning: epan/dissectors/packet-ua3g.c does not have an SVN Id tag.
Error: epan/dissectors/packet-ua3g.c      : {0, NULL} is required as the last
value_string array entry: value_string opcodes_vals_sys[] 
Error: epan/dissectors/packet-ua3g.c      : {0, NULL} is required as the last
value_string array entry: value_string str_return_loss[] 
Error: epan/dissectors/packet-ua3g.c      : {0, NULL} is required as the last
value_string array entry: value_string str_full_duplex[] 
Error: Found prohibited APIs in epan/dissectors/packet-ua3g.c: strcat
Error: Found deprecated APIs in epan/dissectors/packet-ua3g.c: dissector_add
Warning: epan/dissectors/packet-ua.c does not have an SVN Id tag.
Error: Found C++ style comments in epan/dissectors/packet-ua.c
Error: Found deprecated APIs in epan/dissectors/packet-ua.c: dissector_add
Warning: epan/dissectors/packet-uasip.c does not have an SVN Id tag.
Error: the name for field "Sequence Number (sent)    " ("uasip.sntseq") has
trailing space in epan/dissectors/packet-uasip.c
Warning: epan/dissectors/packet-uaudp.c does not have an SVN Id tag.
Error: the name for field "Sequence Number (sent)    " ("uaudp.sntseq") has
trailing space in epan/dissectors/packet-uaudp.c
Error: Found deprecated APIs in epan/dissectors/packet-uaudp.c:
dissector_add,dissector_delete
Warning: epan/dissectors/packet-uaudp.h does not have an SVN Id tag.
./tools/checkAPIs.pl epan/dissectors/packet-noe.c 
Error: Found %ll in epan/dissectors/packet-noe.c
Warning: epan/dissectors/packet-noe.c does not have an SVN Id tag.
Error: the name for field "Length  " ("noe.length") has trailing space in
epan/dissectors/packet-noe.c
Error: the name for field "Server  " ("noe.server") has trailing space in
epan/dissectors/packet-noe.c
Error: the name for field "Ack     " ("noe.method_ack") has trailing space in
epan/dissectors/packet-noe.c
Error: the name for field "Method  " ("noe.method") has trailing space in
epan/dissectors/packet-noe.c
Error: the name for field "Class   " ("noe.class") has trailing space in
epan/dissectors/packet-noe.c
Error: the name for field "Event   " ("noe.event") has trailing space in
epan/dissectors/packet-noe.c
Error: Found C++ style comments in epan/dissectors/packet-noe.c
epan/dissectors/packet-noe.c: found 23 useless add_text() vs. 11 add_<something
else>() calls (209.09%)
Error: epan/dissectors/packet-noe.c       : {0, NULL} is required as the last
value_string array entry: value_string val_str_class[] 
Error: epan/dissectors/packet-noe.c       : {0, NULL} is required as the last
value_string array entry: value_string val_str_props[] 
Error: epan/dissectors/packet-noe.c       : {0, NULL} is required as the last
value_string array entry: value_string val_str_event[] 
Error: Found deprecated APIs in epan/dissectors/packet-noe.c: dissector_add

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.