https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3096
--- Comment #60 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-02-20 13:20:34 PST ---
(In reply to comment #58)
> Created attachment 7861 [details]
> version_info: new function get_os_version_info() and shb_os option string
> length
>
> Summary:
> The attached patch adds a new function - get_os_version_info() - to the
> version_info module and uses it in dumpcap to fill the shb_os option value.
>
> Current status:
> Rev 41026 added support for the option shb_os in dumpcap and started filling
> its value using get_runtime_version_info(). The problem is that the
> runtime_version_info string is usually longer than 100 bytes and it exposed a
> "nasty" limitation in previous versions of the Wiretap API that rendered the
> newly created pcapng files unreadable with older versions of Wireshark (see bug
> #6846). A patch for the problem has already been committed in branch-1.6 and
> queued for branch-1.4 (revision 41037).
>
> The function get_os_version_info() would allow the shb_os string length to stay
> below the 100 bytes threshold (thus minimizing the exposure to bug #6846) and
> would also make the its value a little more compliant to its description in the
> spec. Note: The code of this function was previously in
> get_runtime_version_info().
>
> I think the runtime version information should still be added as an option,
> maybe in a opt_comment, or in a new one (would require the registration oa a
> new option for that purpose).
>
> Comments and/or suggestions are welcome?
> jpo
>
>
>
> shb_os value from get_runtime_version_info()
> ----------
> I: Section 1 options retrieved
> O: Option code 3 = 'on Linux 3.2.5-3.fc16.x86_64, with locale en_US.UTF-8,
> with libpcap version
> 1.2.1, with libz 1.2.5.
>
> Built using gcc 4.6.2 20111027 (Red Hat 4.6.2-1).
> '
> O: Option code 4 = 'Dumpcap 1.7.1-SVN-41080 (SVN Rev Unknown from
> unknown)'
> ----------
>
>
> shb_os value from get_os_version_info()
> ----------
> I: Section 1 options retrieved
> O: Option code 3 = 'Linux 3.2.5-3.fc16.x86_64'
> O: Option code 4 = 'Dumpcap 1.7.1-SVN-41080 (SVN Rev Unknown from
> unknown)'
> ----------
Committed revision 41086. I ment to come back and do something like that :-)
If_os should probably be filled in the same way.
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
