Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6835] patch to add hazelcast dissector, fuzzed for 2hrs

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6835

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #6 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-16 09:14:19 PST ---
Hi Paul,

Quick Review
Checkhf and checkAPI tools is not happy :
Unused entry: epan/dissectors/packet-hazelcast.c, hf_hazelcast_pdu_type
Warning: epan/dissectors/packet-hazelcast.c does not have an SVN Id tag.

About the Warning, there is missing the Copyright in the top (and Modelines
info in the end) of the file and some function need to be in the end of file
(proto_reg* function) , (See 1.2 Skeleton Code in Readme.dev )

(In reply to comment #3)
> The port is not IANA registered as far as I can tell,
> 
>                  5697-5712            Unassigned
> 
Please add a port preference

Also there is some clang Warning :
packet-hazelcast.c:494:3: warning: Value stored to 'clientFlag' is never read
packet-hazelcast.c:553:3: warning: Value stored to 'indexCount' is never read
packet-hazelcast.c:569:4: warning: Value stored to 'offset' is never read

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.