Wireshark-bugs: [Wireshark-bugs] [Bug 5451] RTP-MIDI - dissector for transmission of MIDI-comman
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5451
--- Comment #8 from Tobias Erichsen <t.erichsen@xxxxxx> 2012-02-11 13:56:18 PST ---
(In reply to comment #4)
Unfortunately I have been busy for quite some time,
so the suggested changes took a little longer ;-)
> quick review:
> Use of "" should be replaced by meaningful 'unknown value' message.
>
> These codes snippets
> /* Can we read the program change chapter? */
> if ( ( offset + 3 ) > tvb->length ) {
> return -1;
> }
>
> should make use of calls to tvb_bytes_exist()
All suggested changes above now applied...
> I recommend against using 97 as default payload type, since every one and it's
> mother *assume* that this dynamic value would be available...
Concerning the payload-type, that is the one that is ALWAYS in the network-
MIDI via Apple (apple-midi) and if you look at that dissector, I do forward
packets there to the RTP-dissector... If you have a suggestion for a better
way to do this, let me know...
Best regards,
Tobias
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
