Wireshark-bugs: [Wireshark-bugs] [Bug 6807] RFC 4684 (Constrained Route Distribution for BGP/MPL
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6807
--- Comment #5 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-02-09 09:00:22 PST ---
(In reply to comment #4)
> Created attachment 7802 [details]
> Revised patch for RFC 4684 support
>
> > Please also prefer proto_tree_add_item (and not proto_tree_add_text, it is not filereable...)
>
> Currently other extended communities are handled with proto_tree_add_text. To
> be consistent with that, I also use proto_tree_add_text instead of
> proto_tree_add_item.
>
Yes, I known...
> It makes sense to convert all of extended communities handling to
> proto_tree_add_item to make it filterable, but it's not exactly related to the
> problem the patch tries to solve. Maybe I can do it as separate submission.
Yes but when there is new code, it is better to make the item filterable...
(not need rework after to put the item filterable !)
>
> > Also don't not use memcpy... use tvb_ function (See Readme.dev guide)
>
> Fixed. I hope I got tvb memory management right. Please review.
I will check !
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
