https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3096
--- Comment #23 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-02-09 07:27:29 PST ---
(In reply to comment #22)
> (In reply to comment #21)
> >
> > I'll try adding updating my patch to add the comments to the protocol tree.
> >
> ok, that's obsolete now (the rest of my remarks hopefully isn't)
> I'll have a look at your patches and see if I can find more example files with
> comments in them
Hi,
I think there is tree issues
- How to make the data avilable (wtap), in the case of pcapng there is a couple
of more peices of information that can be of interest.
- "Storing" the data, as Guy pointed out having it in the frame data structure
carries an overhead as ther might be many packets. I contemplated using
pfd; /**< Per frame proto data */
perhaps that's a better idea. I'd make it belong to the Frame dissector then.
(BTW is all 5 nstime_t structs needed, couldn't
the "others" be computed from the first one using a smaller member containing
"offset").
- Presenting the data. Is "my way" better than the tooltip one or do we need
someting entierly different? One could perhaps popup a new treeview with all
comments like the expert info or add that as well?
As for writing comments I have no idea how difficult that would be. from a GUI
perspective we should probably add an "Edit comment" menu to the packet tree
view popup.
Reagrds
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
