Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6787] Move Y.1711 out of MPLS dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6787

--- Comment #3 from FF <francesco.fondelli@xxxxxxxxx> 2012-02-06 06:35:39 PST ---
(In reply to comment #1)
> Would now be the time to:
> 
> 1) Make the proto_tree_add_text(... "Error:") calls into expert infos
> (presumably after actually adding the fields in a filterable way)?
> 2) Replace (most of) the rest of the add_text calls with filterable fields
> (e.g., change the add_text to add_item or add_int, etc.)?

Hi Jeff, Anders,

thanks for your time

I understand that having them filterable is the right thing 
to do (+ expert info) but please note:

1) nobody is using Y.1711 on this planet but very very few person
2) I can do it later after you check the patch in otherwise I need 
to re-spin the patch anytime packet-mpls.c get modified
3) I would like to clean packet-mpls.c up further, this is just the first 
step and I'm kind of blocked

hope this make sense
thank you
ciao
FF

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.