Wireshark-bugs: [Wireshark-bugs] [Bug 6786] openSAFETY: Bugfix SNMT messages malformed 2. frame
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6786
--- Comment #6 from Roland Knall <rknall@xxxxxxxxx> 2012-02-03 14:19:27 PST ---
(In reply to comment #5)
> Odd, there were *some* (but not all) lines in the patch with ^M's (DOS line
> endings) in them. Anyway, I managed to apply the patch.
Ok, my bad again. Used a text editor to change the patch, as the change is
minor, and worked before I skipped the checkup with fuzztest.
But I ran the fuzztest and utils on the original version of the patch, so it
shouldn't matter
> I did note that checkhf finds some issues with the dissector; can these hf's be
> removed?
>
> Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_segment_size
> Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_data
> Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_sacmd_reserved
> Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_sano
> Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_inhibit_time
There are parts of the openSAFETY specification, which are prepared to be put
inside the stack, but are not actually in it yet. They will be in future
versions, and then I will put the codes into dissector.
So, they basically exists as a reminder for me.
> Lastly, where are there some sample captures of this protocol? The bugs listed
> in the dissector's history don't have any (except for one fuzz failure) and
> neither does the wiki's SampleCaptures page. Could you add some to a bug
> (maybe this bug) both for our regression testing and automatic fuzz testing?
>
> Anyway, thanks for the contribution!
I will add some to the SampleCaptures page on Monday, as I do have them at my
office. Is this the same method to add them to regression testing and automatic
fuzz testing? If not, please tell me how, to add the files.
kind regards
Roland
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
