Wireshark-bugs: [Wireshark-bugs] [Bug 3480] Build Browse Information File per default
Date: Mon, 30 Jan 2012 06:54:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3480

--- Comment #5 from Bill Meier <wmeier@xxxxxxxxxxx> 2012-01-30 06:54:27 PST ---
(In reply to comment #4)
> Most of this patch is applied in revision 40765.
> ...
> Do we want to make it the default? 

  My vote: No; I would, however, change the Makefile so that defining an
  environment variable (without needing to edit config.nmake and
  Makefile.nmake) would cause /FR to be used and the bsc file to be generated .

> some large files produce warnings should we
> try to skipp those?

  Yes for 

    packet-nbap
    packet-ncp2222
    packet-rrc
    packet-x11
    packet-parlay

   asn1\nbap\nbap.cnf(38510) : warning BK4504 : file contains too many
     references; ignoring further references from this source
   epan\dissectors\packet-ncp2222.c(25324) : ...
   asn1\rrc\rrc.cnf(1548) : ...
   epan\dissectors\x11-extension-implementation.h(23357) : ...
   plugins\giop\packet-parlay.c(17653) : ...

Also: I don't think there's any reason to generate .sbr files when building
tools such as lemon and when building a library such as portaudio.
That is: I'd add /FR to STANDARD_CFLAGS rather than LOCAL_CFLAGS.

---------

I'll commit the changes in a day or so if there are no concerns....

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.