Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6758] Dissector for the Sony FeliCa Protocol

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6758

Tyson Key <tyson.key@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyson.key@xxxxxxxxx

--- Comment #4 from Tyson Key <tyson.key@xxxxxxxxx> 2012-01-24 04:33:06 PST ---
(In reply to comment #3)
> Comment on attachment 7722 [details]
> A version of the dissector with cleaned up comments
> 
> Never manipulate column info or place a subdissector call inside an 'if (tree)'
> block.
> 
> What are the felica_handle and felica_dissector_table for?

Thanks for the review, Jaap. 

Those variables are vestigial from the dissector that I adapted to create this
one (the MiFare dissector). I haven't got around to seeing if things still work
after removing them.

If I can't manipulate the information column, or call subdissectors from within
if(tree), do you have any suggestions for alternative methods? (Keeping in mind
that FeliCa's application layer doesn't have any notion of a "packet
direction", and that I'm intending on calling this dissector from a future
wrapper protocol dissector).

Tyson.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.