Wireshark-bugs: [Wireshark-bugs] [Bug 6375] GPRS RLCMAC dissector not handling valid PDU
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6375
--- Comment #2 from Mike Morrin <wireshark@xxxxxxxxxxxxxxx> 2012-01-20 10:28:11 PST ---
I have prepared a patch which improves several aspects of GSM RLS/MAC
dissection.
Generic improvements to the csn.1 dissector include:
• Added a flag to the type descriptor structure so that any type can
(potentially) flagged as xxx_OR_NULL. This was specifically needed for
UINT_OR_NULL for the ms capabilities struct.
• Corrected the octet calculation in app of the proto_tree_add_text() and
proto_item_set_len() calls.
• Changed the CSN_SERIALIZE so that the length of the length field can be
specified.
• For CSN_NEXT_EXIST removed the requirement that the next type be CSN_END,
to allow truncation of multiple IEs.
• For CSN_LEFT_ALIGNED_VAR_BITMAP corrected the handling of bit_offset.
• Added a new type CSN_PADDING_BITS to make inspection of padding bits more
convenient.
• Improved the CSN_RECURSIVE_TARRAY_1 to show the array index.
Improvements to the gsm_rlcmac dissector include:
• Comment out a couple of unused hf variables.
• Rework the definition of EGPRS Ack/Nack Description so that the length IE
(and absence thereof) is handled correctly. This is the original issue for
which the bug was raised.
• Added Padding Bits definitions to all PDUs
• Change the Multislot_capability_t and Content_t definitions to allow
truncation at any IE
• Added proto_tree_add_protocol_format() calls so that the protocol can be
added to a display filter
• Append Protocol to the PROTOCOL column and PDU type to the INFO column.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
