https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5469
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7471|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #7 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-12-29 10:27:35 PST ---
(From update of attachment 7471)
Since the gtk-vnc bug has been fixed, do we bother making any changes at this
point? Well, either way, this patch is being rejected since the
expert_add_info_format() call can't be within an if (tree) block. And when
will pinfo ever be NULL? It is dereferenced all over the place, so if it can
be NULL, then it would need to be checked in many more places than this. Also,
I'm not sure returning TRUE if the data violates the protocol is a good idea
either.
Regarding the other changes for the minor cleanup, perhaps it would be better
to open a separate bug report and post a patch with only those changes?
Especially since I'm really considering closing this bug as wontfix.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
