Wireshark-bugs: [Wireshark-bugs] [Bug 5315] Add Dissector for Astaro's RED Protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5315
--- Comment #6 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-12-28 19:09:33 PST ---
(In reply to comment #1)
> Created an attachment (id=5331)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5331) [details]
> Packet dissector patch
Some feedback on the patch in addition to Jeff's feedback in comment 4:
1) packet-who.c -> packet-red.c
2) Simplify adding items to trees by using only a single if (tree) block.
3) proto_tree_add_item(..., FALSE); -> proto_tree_add_item(...,
ENC_BIG_ENDIAN|ENC_NA), as appropriate.
4) dissector_add() -> dissector_add_uint()
And as Jeff already mentioned, port 3400 is registered with IANA as CSMS2, so
packet-red should be turned into either a new-style or a heuristic dissector.
Read README.developer and README.heuristic for more information.
Additionally, is there any documentation available for this protocol? Has it
been fuzz-tested? Has it passed all the tools/check*.pl scripts? It might
even be useful if you could add a wiki page that describes this protocol.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
