Wireshark-bugs: [Wireshark-bugs] [Bug 6573] tvbuff_t values leak if they have a child tvbuff_t (
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6573
Bill Meier <wmeier@xxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #5 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-12-22 09:25:38 EST ---
(In reply to comment #4)
> Thanks for the patch with the suggested fixes !
>
> You've obviously spent some time looking at and understanding the tvbuff code.
>
> That being said, upon spending some time looking at the tvbuff.c code myself,
> I came to the conclusion that maybe it's not really necessary to keep
> usage_counts & used_in lists at all given the way Wireshark uses tvbuffs.
>
> If so, then the code can be simplified and we don't have to go thru
> contortions to try to get everything correct.
>
Ok: I've committed a version of the tvbuff code which doesn't keep usage_counts
and used_in lists (SVN #40264). So far there haven't been any reports of
problems.
I've also committed your changes to tvbtest as well as additional changes.
The additional changes included fixes for some bugs which caused the composite
tvb tests to fail.
All of the tests in tvbtest now run successfully. In addition, valgrind shows
no memory leaks.
Again, thanks for the patches. Although I decided to do a different patch to
tvbuff.c to fix the problem, your efforts are certainly appreciated.
(I'm marking the patch as 'not accepted' only because I decided to do something
different).
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
