Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6672] openSAFETY: Code clean up, various improvements and bugfixes

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6672

Roland Knall <rknall@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7585|0                           |1
        is obsolete|                            |
   Attachment #7587|                            |review_for_checkin?
               Flag|                            |

--- Comment #3 from Roland Knall <rknall@xxxxxxxxx> 2011-12-15 01:39:22 PST ---
Created an attachment (id=7587)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7587)
Various changes and improvements to the opensafety dissector

Hi

Two additional things have been fixed in this patch version:

- Ander's comment regarding "Value strings must be terminated with" has been
implemented in a way suitable for the dissector. The value_string
sn_fail_error_code has been removed as it is unused.
- checkAPIs.pl has been performed, and returned no unallowed functions 

- Additionally there was an issue, where tshark would not display the correct
column info, as it was generated only if ( tree != NULL ). This has been
corrected


As always I ran fuzztest and randpkt and they passed the dissector.

regards,
Roland

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.