Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5881] Media Independent handover (MIH) protocol dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881

Ankith <ankitha@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7529|review_for_checkin?         |
               Flag|                            |
   Attachment #7529|0                           |1
        is obsolete|                            |
   Attachment #7565|                            |review_for_checkin?
               Flag|                            |

--- Comment #21 from Ankith <ankitha@xxxxxxx> 2011-12-11 21:27:52 PST ---
Created an attachment (id=7565)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7565)
MIH protocol dissector patch

1)It is not possible to replace proto_tree_add_text by proto_tree_add_item ?
(Make field filterable ?
 --> the proto_tree_add_text at line no. 591 (for dissection of MIH type), is
used to make the output more readable. However the MIh type field is
filterable, because it is used when the corresponding tree is expanded.
 --> If there is anywhere else I have to change the API please let me know the
line number.

2)Also for function dissect_cmd_list / dissect_evt_list / dissect_mob_mgmt /
dissect_cfg_mthds, why not use value_string ?
 --> A value_string datatype cannot be used because these functions dissect a
Bitmap, ie, each bit specifies whether the corresponding event is supported, so
all the if conditions are to be checked. If there is any better solution please
let me know. 

3)Also there is same Clang Warning : 
packet-mih.c:544:25: warning: Value stored to 'item' is never read
packet-mih.c:529:25: warning: Value stored to 'item' is never read
packet-mih.c:539:25: warning: Value stored to 'item' is never read
packet-mih.c:534:25: warning: Value stored to 'item' is never read
packet-mih.c:504:9: warning: Value stored to 'item' is never read
packet-mih.c:512:17: warning: Value stored to 'item' is never read
packet-mih.c:808:24: warning: Value stored to 'offset' is never read
packet-mih.c:871:25: warning: Value stored to 'temp' is never read
packet-mih.c:882:25: warning: Value stored to 'temp' is never read
packet-mih.c:860:25: warning: Value stored to 'temp' is never read
 --> the unused variables are removed.

Thank you for your comments.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.