Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5881] Media Independent handover (MIH) protocol dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881

--- Comment #14 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-12-04 22:52:25 CET ---
Quick review:
Never ever wrap col_* functions in 'if (tree)' conditions.
Your dissect_* functions should all be static.
Use consistent indentation, spaces are preferred.
No C++ style comments allowed for portability reasons.
Have a look at proto_tree_add_boolean_bits_* for bitfield dissection.
dissect_link_param_rpt always shows BELOW THRESHOLD
You could use more proto_tree_add_item's i.s.o. proto_tree_add_text
Using symbols like MIHF_ID, i.s.o. 52, make the source more readable
Header fields don't need colons at the end of the labels
dissector_add is deprecated for dissector_add_uint in this case

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.