Wireshark-bugs: [Wireshark-bugs] [Bug 6082] Enhancement of Hilscher Analyzer Dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6082
--- Comment #12 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-11-14 05:21:12 PST ---
(In reply to comment #11)
> There is a problem in the length-decoding.
> Before I submit a patch I would like to ask you if there is a specific reeason
> for decoding the port (hf_netanalyzer_port) and length (hf_netanalyer_length)
> as bit-field using proto_tree_add_item. In my original version I uses
> proto_tree_add_unit in order to avoid displaying the bit-fields. For this case
> the bit-field display does not make much sense for the user. I would appreciate
> to use my original implementation for that, is that ok?
I suppose, but to me displaying it as a bit field seems like the right thing
to do, the port is the first two bits isn't it? perhaps the field should just
be 8 bits wide?
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
