Wireshark-bugs: [Wireshark-bugs] [Bug 6462] Added NFSv4 error status to packet detail window.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 28 Oct 2011 07:01:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6462

--- Comment #2 from Steve Dickson <steved@xxxxxxxxxx> 2011-10-28 07:01:32 PDT ---
(In reply to comment #1)
> Your patch is enhance of patch proposed in Bug #6078 but not include
> recommendation of Chris :
> 
> > You don't append text to proto_trees; you append them to proto_items.  And what
> > happens if ops is zero?  I think it would be better to only call the initial
> > proto_item_append_text() if ops is non-zero.  And within the for() loop, you
> > might consider using the plurality macro to comma-separate the ops, i.e.
> > something like: 
> >  proto_item_append_text(item, " %s%c", val_to_str(opcode,
> > names_nfsv4_operation, "Unknown"), plurality(ops, '\0', ','));
> 
> About the append text use the function proto_tree_get_parent to get the item of
> tree.
Are you saying change things like
    proto_item_append_text(tree, " %s", opname);
to
   proto_item_append_text(proto_tree_get_parent(tree), " %s", opname);

If so, should that change be made just in my patch or
throughout the entire file?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.