Wireshark-bugs: [Wireshark-bugs] [Bug 6510] Harden buffer_assure_space to avoid integer overflow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 27 Oct 2011 23:03:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6510

--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2011-10-27 23:03:57 PDT ---
The Wiretap modules already impose a Wireshark-wide limit on the size of
records from a capture file to prevent memory allocation from failing.  That
should prevent buffer->allocated from getting much bigger than
WTAP_MAX_PACKET_SIZE, which should prevent this from happening.  (If we're not
checking for a too-large packet size in any module, that's a bug that needs
fixing.)

Alternatively, we could put the enforcement of the maximum packet size into
buffer_assure_space(), which could make it less likely that somebody will
forget to do their own packet-size checks into a file-type module.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.