Wireshark-bugs: [Wireshark-bugs] [Bug 6507] New: DVB-CI / CI+ Operator Profile Resource
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 27 Oct 2011 12:40:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6507

           Summary: DVB-CI / CI+  Operator Profile Resource
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: wireshark@xxxxxxxxx


Created an attachment (id=7323)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7323)
DVB-CI/CI+ Operator Profile resource

Build Information:
TShark 1.7.0 (SVN Rev 39637 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GLib 2.24.2, with libpcap 1.1.1, with libz 1.2.3.4,
without POSIX capabilities, with threads support, without SMI, without c-ares,
without ADNS, without Lua, without Python, with GnuTLS 2.8.6, with Gcrypt
1.4.5,
with MIT Kerberos, without GeoIP.

Running on Linux 2.6.32-5-amd64, with locale en_US.UTF-8, with libpcap version
1.1.1, with libz 1.2.3.4.

Built using gcc 4.4.5.

--

Dear all,

the attached adds the CI+ Operator Profile Resource to the DVB-CI dissector.
When this goes in, the dissector has complete support for CI+ version 1.3.1
that was published earlier this week.

Strings are using ENC_ASCII|ENC_NA.

Interestingly, checkhf.pl brings up two warnings
$ ./tools/checkhf.pl epan/dissectors/packet-dvbci.c 
Unused entry: epan/dissectors/packet-dvbci.c, hf_dvbci_opp_desc_loop
Unused entry: epan/dissectors/packet-dvbci.c, hf_dvbci_hc_desc_loop

This is a false alarm, these hf_ variables are used indirectly as function
parameters.

I hope that 
item_len = (guint)ftype_length(proto_registrar_get_nth(item_hf)->type);

is a reasonable way to find out how many bytes must be read to fill an hf
variable (3 bytes for FT_UINT24 etc).

Other than that, there's nothing special. Code is fuzz-tested, sample capture
is attached.

Thanks for feedback, merging.

Best regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.