Wireshark-bugs: [Wireshark-bugs] [Bug 6426] Added execute parameters decoder to MySQL dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 19 Oct 2011 13:00:12 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6426

András Veres-Szentkirályi <vsza@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7138|0                           |1
        is obsolete|                            |
   Attachment #7266|                            |review_for_checkin?
               Flag|                            |

--- Comment #5 from András Veres-Szentkirályi <vsza@xxxxxxx> 2011-10-19 13:00:11 PDT ---
Created an attachment (id=7266)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7266)
Proposed patch v2

1) OK, fixed (I found _U_ but wasn't sure if it's OK to use it.)
2) I removed g_hash_table destroy, because I could reproduce situations, where
the tree was destroyed before the execute packet was dissected. I agree, that
it's a leak, and didn't know of se_trees -- I managed to rewrite it to use them
(and got rid of #include <glib.h>)
3) I modified it to use ENC_ASCII, although strings are transmitted using the
charset of the connection (there are 29 of those)

I attached the modified (and hopefully improved) patch.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.