Wireshark-bugs: [Wireshark-bugs] [Bug 5784] New dissector for GSM A-bis OML
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 18 Oct 2011 18:36:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5784

--- Comment #7 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-10-18 18:36:47 PDT ---
__attribute__ ((packed)) isn't portable--that's gotta go.

And I'm pretty uncomfortable with all this mucking around inside of
value_string_ext's.  AFAICS this is to use different value_strings for the same
hf entry depending on a preference.  Why not just use 2 hf's?  Or use
BASE_CUSTOM?  (This poking around makes me think value_string_ext's should be
opaque--but that probably wouldn't be easy.)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.