Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6467] Add Binary JSON (BSON) decoding support to Mongo packet dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6467

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7262|review_for_checkin?         |review_for_checkin-
               Flag|                            |

--- Comment #2 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-10-18 16:18:51 PDT ---
(From update of attachment 7262)
Quick Review :
Checkhf is not happy : 
./tools/checkhf.pl epan/dissectors/packet-mongo.c
Unused entry: epan/dissectors/packet-mongo.c,
hf_mongo_element_value_binary_type
Unused entry: epan/dissectors/packet-mongo.c, hf_mongo_document
Unused entry: epan/dissectors/packet-mongo.c, hf_mongo_element_value_null

Also there is some Clang compiler Warning : packet-mongo.c:348:9: warning:
Value stored to 'e_len' is never read
packet-mongo.c:302:9: warning: Value stored to 'b_type' is never read
packet-mongo.c:259:3: warning: Value stored to 'doc' is never read

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.