Wireshark-bugs: [Wireshark-bugs] [Bug 6440] Wireshark dissector for EIGRP and SAF
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 14 Oct 2011 06:30:52 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6440

--- Comment #14 from Donnie Savage <diivious@xxxxxxxxxxx> 2011-10-14 06:30:51 PDT ---
(In reply to comment #12)
> Coverity reports a CONSTANT EXPRESSION RESULT bug in CID 1310 at line 1762:
> 
> Event result_independent_of_operands: (tlv & 0xf) == (516 /* 0x200 | 4 */) is
> always false regardless of the values of its operands (logical operand of if).
> 1762         if ((tlv & EIGRP_TLV_TYPEMASK) == EIGRP_TLV_AT_CBL) {

You are correct -this should have been:

    if (tlv == EIGRP_TLV_AT_CBL) {

do you want me to commit this fix?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.