Wireshark-bugs: [Wireshark-bugs] [Bug 6452] packet-ajp13 fix, cleanup, and enhancement
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 12 Oct 2011 23:03:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6452

--- Comment #8 from Iain Arnell <iarnell@xxxxxxxxx> 2011-10-12 23:03:02 PDT ---
(In reply to comment #4)

Thanks for the review.

> appears to be setting hf_ajp13_aval to have as its value the attribute *name*,
> not its *value*.

Yeah, that's the same way the existing code is handling the headers too. I
think what's really needed here is for the defined ajp13 headers and attributes
each to have its own header field (much like the http dissector).

> In addition, it appears that the attribute type
> ATYPE_SSL_KEY_SIZE has a numerical value, while other attribute types have
> string values, so you might need two different fields for the attribute value.

Would be handled properly with separated fields.

Update will come later - either here or a new bug if you prefer.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.