Wireshark-bugs: [Wireshark-bugs] [Bug 6430] BRP Protocol Preference Addition
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 5 Oct 2011 10:19:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6430

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeff.morriss.ws@xxxxxxxxx

--- Comment #8 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-10-05 10:19:48 PDT ---
Personally I prefer port registration (possibly as a preference) + being a
new-style dissector[1] to being heuristic.  If you know that 99% of the time
traffic for your dissector is on, say, port 1958, there's relatively little
need to be a true heuristic dissector that gets (thus far unclaimed) traffic on
all other ports.  I don't think we really want to go down the route of having
hundreds of heuristic dissectors...  (Imagine the cycles wasted when the packet
is really unknown to Wireshark.)

[1] a new-style dissector calls new_register_dissector() and does some
heuristics before accepting the packet handed to it; if it thinks the packet
does not belong to it then it returns 0.  Else it returns the number of bytes
of the packet it consumed.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.