Wireshark-bugs: [Wireshark-bugs] [Bug 6179] Allow time-shifting of the packet trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6179
--- Comment #22 from Edwin Groothuis <wireshark@xxxxxxxxxxx> 2011-08-14 04:06:03 PDT ---
(In reply to comment #20)
> (In reply to comment #19)
> > Can you give me the trace and the values you used?
>
> Just open a random capture file and use this values:
> "Set packets to time and extrapolate"
> Packet number: 1
> Set packet to time: 2:0:0
> Packet number: 10
> Set packet to time: 3:0:0
Wow. Wonder which funky overflow you found with that one.
I never used such large values, just differences of seconds over large amount
of packets.
> > Or did you use it on live capture (Can we detect if a capture is happening? In
> > that case we should disable this option)
>
> I did not try on live capture.
> We have a live capture if (cfile.state != FILE_CLOSED).
Thanks for that hint.
> > > 5. Isn't "Ctrl-A" used for select all? Maybe find another shortcut?
> > See comment 13 I believe. Your commit has already removed it, didn't it?
> I removed it, but maybe we should add another one?
See the comments with regarding to a second entry to undo the shifting.
> When using "Shift all packets" the settings are applied when pressing "Apply",
> and then once more when pressing "Ok". This may not be what the user really
> wants?
He should have shifted it with half the values if he understood what the
function works :-)
That leaves the question: If you press cancel, what has to happen if you have
already applied once or twice? Maybe get rid of the Cancel / Apply / Ok buttons
and changing them into Apply and Close? I think that would make more sense.
Edwin
Edwin
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
