Wireshark-bugs: [Wireshark-bugs] [Bug 6232] No error for UDP/IPv6 packet with zero checksum
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 11 Aug 2011 11:14:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6232

--- Comment #7 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-08-11 20:14:48 CEST ---
(In reply to comment #2)
> I think what need:
> --- epan/dissectors/packet-udp.c
> +++ epan/dissectors/packet-udp.c
> @@ -421,1 +421,1 @@
>  if (udph->uh_sum == 0) {
>      /* No checksum supplied in the packet. */
> -    if (ip_proto == IP_PROTO_UDP) {
> +    if ((ip_proto == IP_PROTO_UDP) && (pinfo->src.type != AT_IPv6)) {
> 
> Since, in theory, UDP can not be just over IP.

UDP does require to run over IP, due to the pseudoheader required for checksum
calculation. At least that is what the UDP dissector enforces.

Hence, either patch works, mine looks clearer, IMHO.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.