Wireshark-bugs: [Wireshark-bugs] [Bug 6222] Submit patch for DHCPv6 DS-Lite AFTR Option RFC 6334
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 11 Aug 2011 00:55:52 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6222

--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-08-11 09:55:50 CEST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 6796 [details] [details] [details])
> > > This hasn't shown up in trunk, so I think Jaap meant to set it to "?".
> > 
> > No, I meant to set it to "+" as in "I approve of this patch". The fact that the
> > bug is open is because I didn't/couldn't commit this change (dev system still
> > down after moving :( ).
> 
> But doing that takes it out of the list of pending patches, somewhat defeating
> the purpose of the flag, no?

So who goes about committing a patch, go into details, set it to plus, submit,
add commit revision number to bug text, resolve bug, commit? Not happening. 

So, IMHO, pending patch should be listed when 
 !(bug.status == resolved || attachment.flag.request_for_review == '-')

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.