Wireshark-bugs: [Wireshark-bugs] [Bug 6207] Add the ability to save filters from the Filter Tool
Date: Sun, 7 Aug 2011 03:10:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6207

--- Comment #9 from Edwin Groothuis <wireshark@xxxxxxxxxxx> 2011-08-07 03:10:01 PDT ---
Hello Stig,

(In reply to comment #8)
> 1. The "Preferences -> Filter Expressions" should be a list (like in "User
> Interface -> Columns", or maybe like the "Coloring Rules"), where you can add,
> change, enable, disable, delete and reorder entries.

I will modify it.
Keep in mind that my GTK skills are far below what is needed here, I did most
of it with copy+paste+curse+change+backout+copy+paste+sighrelieved.

> 2. The preferences are stored in each profile, so when changing profile the
> buttons must be redrawn for the selected profile.  It also seems like the
> preferences are added to the existing preferences when changing profile, which
> must be a bug.

Will take it into account.

> 3. When saving a filter string the preferences should automatically be saved so
> we don't need a warning each time.

Would be nicest.

> 4. It should be possible to change and delete buttons directly from the button
> row, and maybe a link to the preferences settings?  This could be available
> from a second-click popup menu like we have in the packet list headings.

See the 2nd comment of 1.

> 5. I get this warning when closing the preferences:
> (wireshark:71435): Gtk-CRITICAL **: gtk_widget_destroy: assertion
> `GTK_IS_WIDGET (widget)' failed

I didn't see but will keep an eye on it.

Edwin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.