Wireshark-bugs: [Wireshark-bugs] [Bug 6017] No Cisco FabricPath protocol dissector included
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 14 Jun 2011 03:51:38 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6017

--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-06-14 12:51:37 CEST ---
+  //dissector_add("ethertype", ETHERTYPE_DTAG, fp_handle);
+  heur_dissector_add ("eth", dissect_fp_heur, proto_fp);

I would prefer registration of the ethertype (using dissector_add_uint()),
i.s.o. heuristically process *all* ethernet frames, most of which are unlikely
to be MiM packets for most people. 

If that's not feasible a preference (by default off) for heuristics would be
preferred. See packet-hilscher.c for the example. packet-tte.c should be
probably done the same way.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.