Wireshark-bugs: [Wireshark-bugs] [Bug 5956] kNet (KristalliNet) dissector for Wireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 26 May 2011 07:58:38 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5956

--- Comment #5 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-05-26 16:58:37 CEST ---
Quick review:
Please convert to build in dissector.
Please provide only source files, not all build, intermediate, etc.
Please use boilerplate header for source files.
Please use boilerplate for function order in source files.
UDP/TCP port used is IANA assigned to 'dbm', make port configurable/dissector
heuristic.
Compressed is to be a preference.
'pinfo = pinfo;' has to be solved with 'pinfo _U_' in the function interface.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.