Wireshark-bugs: [Wireshark-bugs] [Bug 5924] New: dccp (and possibly WS) coding style
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 15 May 2011 10:52:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5924

           Summary: dccp (and possibly WS) coding style
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: francesco.fondelli@xxxxxxxxx


Created an attachment (id=6348)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6348)
dccp-ws-code-style.patch

Build Information:
wireshark 1.5.2 (SVN Rev 37139 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.24.4, with GLib 2.28.6, with libpcap 1.1.1, with
libz 1.2.5, with POSIX capabilities (Linux), without libpcre, with SMI 0.4.8,
without c-ares, without ADNS, without Lua, without Python, with GnuTLS 2.10.5,
with Gcrypt 1.4.6, without Kerberos, without GeoIP, without PortAudio, without
AirPcap.

Running on Linux 2.6.37.6-smp, with libpcap version 1.1.1, with libz 1.2.5,
GnuTLS 2.10.5, Gcrypt 1.4.6.

Built using gcc 4.5.2.

--

Hi,

I've been told my coding style sucks...  I normally adapt my coding style to
the one already present.  I wanted to "fix" packet-dccp.[ch] style with
something decent and after several attempts with 'indent' I found the
'uncrustify' tool.  It's a really feature rich and extremely configurable code
beautification tool.

http://uncrustify.sourceforge.net/

I prepared an uncrustify configuration file for Wireshark:
tools/ws-coding-style.cfg (based on examples found somewhere in the Net and
adapted to my taste).

typical usage:

uncrustify -c ../../tools/ws-coding-style.cfg --replace packet-dccp.c
emacs packet-dccp.c /* to make very small changes, uncrustify is not perfect */
svn diff > foo.patch

Please consider adopting tools/ws-coding-style.cfg as a guide in writing
Wireshark code.  Feel free to change any configuration option.

In case you don't care/want to specify any Wireshark coding style please check
in my second patch you find in attach.

thanks
ciao
FF

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.