Wireshark-bugs: [Wireshark-bugs] [Bug 5175] PPI-GPS protocol dissector patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 12 May 2011 13:57:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5175

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6324|review_for_checkin?         |review_for_checkin-
               Flag|                            |

--- Comment #20 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-05-12 13:57:01 PDT ---
(From update of attachment 6324)
Please don't use tvb_get_ptr(), especially like this:

+                curr_str = (gchar *) tvb_get_ptr(tvb, offset,  32); /* I need
to append_text this */
+                proto_tree_add_string(ppi_gps_tree, hf_ppi_gps_descstr, tvb,
offset, 32, curr_str);

Suggestion: use tvb_get_string() or one of its variants.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.