Wireshark-bugs: [Wireshark-bugs] [Bug 5887] DACP (apple remote) enhancement to DAAP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 4 May 2011 09:08:46 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5887

--- Comment #3 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2011-05-04 10:08:45 MDT ---
Thanks for your patch.  Instead of calling the dissect_png() function directly,
please update the patch to call it using the call_dissector() function. 
Putting png_handle = find_dissector("png") in the proto_reg_handoff_daap()
function and then doing call_dissector(png_handle, tvb, pinfo, tree) should
work.  The png_handle should be a static dissector_handle_t at the top of the
packet-daap.c file.  Also it looks like packet-image-png.c needs to register
the png dissector by name first with the register_dissector() function.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.