https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5794
--- Comment #4 from Neil Piercy <Neil.Piercy@xxxxxxxxxxxx> 2011-05-03 02:57:26 PDT ---
(In reply to comment #3)
> 1. I'm pretty sure that ep_alloc instead of se_alloc should be used in the
> following since the reversing buffer will be used only during the dissection of
> the current frame:
>
> ...
> len = tvb_length(tvb);
> reversing_buffer = se_alloc(len);
> memcpy(reversing_buffer, tvb_get_ptr(tvb, offset, -1), len);
> ...
>
> Using se_alloc means that a new buffer will be allocated each time this
> dissector is called and that the buffers will not be freed until
> a complete re-dissection is done (filter changed, file re-opened,
> new file opened, etc).
I did wonder about that, but I wasn't sure about the consequences of the tvbuff
being destroyed after the packet is no longer displayed - is this OK?
> 2. A thought:
<snip>
> (or, maybe this approach is a non-starter given the comment about
> "to do: add dissection of the CBS message payloads").
I think this is the issue: some messages have a payload which needs chaining to
the next protocols layer, so I think we have to at least dissect those - could
perhaps avoid some further dissection with if(tree). If/when I get round to
this I'll take a look.
> ====
>
> P.S. Can you provide a capture file for this protocol ?
Unfortunately the only examples I have use an internal proprietary lower layer
protocol (below FP) for which we do not release dissectors.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
